Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[arrow] Improve findzstd patch #6757

Merged
merged 1 commit into from
Jun 14, 2019
Merged

[arrow] Improve findzstd patch #6757

merged 1 commit into from
Jun 14, 2019

Conversation

Neumann-A
Copy link
Contributor

@Neumann-A Neumann-A commented Jun 4, 2019 •
edited
Loading

find_library call before:

ZSTD_LIBRARY_RELEASE;NAMES;zstd;zstd_staticd.lib;libzstd_staticd.lib;zstdd.dll;
ZSTD_LIBRARY_DEBUG;NAMES;zstdd;zstd_staticd.libd;libzstd_staticd.libd;zstdd.dlld;

after:

ZSTD_LIBRARY_RELEASE;NAMES;zstd;zstd_static;zstd;
ZSTD_LIBRARY_DEBUG;NAMES;zstdd;zstd_staticd;zstdd;

simplying removing the unnecessary extra library postfix.
(In the current state of VCPKG ZSTD_LIBRARY_DEBUG will never be found since zstd does not have an extra debug postfix. Maybe in the future)

@Rastaban Rastaban merged commit aac6c06 into microsoft:master Jun 14, 2019
@Neumann-A Neumann-A deleted the fix_arrow_zstd branch June 21, 2019 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Rastaban Rastaban

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Neumann-A @Rastaban